Make comparisons to today consider only stats in the same exact time range#6205
Open
Make comparisons to today consider only stats in the same exact time range#6205
Conversation
zoldar
force-pushed
the
improve-comparison-to-today
branch
from
5dc9c34 to
395e17b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes behavior when determining time range for "today" when enabling comparisons. Before it, the past time range compared against always included a full day (corrected by site's timezone). Now it only includes the exact time range from midnight relative to the current hour.
The new behavior can be tested live on preview app at https://pr-6205.review.plausible.io/
Technical stuff follows...
I have modified input date range parsing logic in both new and legacy query builders to always make an exception for "day" period when it matches today corrected for site's timezone. When the condition is met:
lasttimestamp of the datetime range is set toquery.now24hperiod instead of generating a time range for the whole day periodTime related logic got refactored very slightly to reduce repetition and allow mixing dates and datetimes when building
DateTimeRange.Tests
Changelog